fix(Spoof Streaming Data): Performance degradation on iOS client #110
Conversation
...hared/src/main/java/app/revanced/extension/shared/patches/spoof/SpoofStreamingDataPatch.java
Outdated
Show resolved
Hide resolved
| ? "Unknown" | ||
| : lastSpoofedClientType.getFriendlyName(); | ||
| } | ||
| private static final Map<String, ClientType> clientTypeMap = Collections.synchronizedMap( |
There was a problem hiding this comment.
Still using two HashMaps, so it's not good in terms of performance
There was a problem hiding this comment.
The performance difference is not noticeable at all (since videoId is used as key). For more information, before this PR you were using streamingData as the map key. It causes significant delay because the map has to hash the entire byte array.
...hared/src/main/java/app/revanced/extension/shared/patches/spoof/SpoofStreamingDataPatch.java
Outdated
Show resolved
Hide resolved
inotia00
changed the title
|
Additional context Before this PR, there was a delay of about 1 second for the video to start on iOS clients, because two HashMaps were used to find the original StreamingData The PR fixes that |
|
Still, there is a delay I will also consider skipping the videoId verification to further reduce the delay (Will be implemented as a setting) |
Uhm u shouldn't do it, since the original StreamingData may be spoofed incorrectly 🫠 Just keep things as they are |
Apply workarounds to
IOSclient only