feat(YouTube - Shorts components): add Custom actions in toolbar setting (YouTube 18.38.44+)

[Francesco146]

open to changes and suggestions.

• i hate litho stuff.

Preview

previously known as: #101

[Francesco146]

i think the whole process can be simplified using this:

revanced-patches/patches/src/main/kotlin/app/revanced/patches/youtube/video/information/Fingerprints.kt

Lines 136 to 157 in e5354e9

	/**
	* This fingerprint is compatible with all versions of YouTube starting from v18.29.38 to supported versions.
	* This method is invoked only in Shorts.
	* Accurate video information is invoked even when the user moves Shorts upward or downward.
	*/
	internal val videoIdFingerprintShorts = legacyFingerprint(
	name = "videoIdFingerprintShorts",
	returnType = "V",
	parameters = listOf(PLAYER_RESPONSE_MODEL_CLASS_DESCRIPTOR),
	opcodes = listOf(
	Opcode.INVOKE_INTERFACE,
	Opcode.MOVE_RESULT_OBJECT
	),
	customFingerprint = custom@{ method, _ ->
	if (method.containsLiteralInstruction(45365621L))
	return@custom true
	method.indexOfFirstInstruction {
	getReference<FieldReference>()?.name == "reelWatchEndpoint"
	} >= 0
	}
	)

if so, why is it not also used on RYD? why in that case we filter the proto buffer?

[YT-Advanced]

if so, why is it not also used on RYD? why in that case we filter the proto buffer?

I think the main reason is the delay. RYD data must be fetched as soon as possible

[Francesco146]

ah okey. then in this context it doesn't make sense to read the id from the buffer, since to open the menu, the id have time to propagate. I'll update the code tomorrow :)

edit:
that fingerprint hooks setVideoInformation, which was used in the very first implementation, but i was told that this information was not reliable due to the pre-loading of multiple Shorts at the same time.

long story short: i need clarification about which implementation to use

[0xrxL]

I'm highly interested to the fourth option (those to open shorts in normal player). Maybe can be implemented in a wat to be triggered at a start of a short.

[Francesco146]

[...]. Maybe can be implemented in a wat to be triggered at a start of a short.

by doing that, you would always be interrupted in scrolling through the videos. i don't know how useful something like that could be

[0xrxL]

[...]. Maybe can be implemented in a wat to be triggered at a start of a short.

by doing that, you would always be interrupted in scrolling through the videos. i don't know how useful something like that could be

Wdym?

[0xrxL]

@Francesco146 ok, now I understand what you were referring to before. Clicking the Short button would trigger many instances of normal player, that would prevent you from swiping down to see more shorts. In this case, however, there is already a fingerprint to map the bottom navigation buttons, so when you'll click the shorts button, only shorts view will be opened.

In this way you'll be able to open normal player for shorts, only in feed/search list.

[Francesco146]

i marked this pr as a draft because it is still missing some key aspects. i think that instead of many implementations of the same thing, it's not the right choice. there are some bugs to fix and this takes some time

[YT-Advanced]

Uhm we should merge all videoId litho filter into something like ShortsVideoIdPatch, since all of these patch do the same functionality (getting Shorts videoId):

• Shorts RYD
• Return YouTube Channel Username
• Custom Action
• Hook Shorts Toolbar

[inotia00]

Considering this PR, dad6b3d was committed

[Francesco146]

i don't think it's a good idea to release this yet, the code is confusing, duplicated and not documented

[inotia00]

Refactoring ShortsVideoIdPatch should be done via another PR, but I don't think it's necessary right now

Even if it is implemented, it won't resolve issues like inotia00/ReVanced_Extended#1538 or inotia00/ReVanced_Extended#1547

[Francesco146]

ok, 9e50e0d broke backgroundPlaybackPatch, be aware of that

[inotia00]

Not all the code I'm working on locally has been merged into the dev branch yet

It will be tested for functional issues before a new release