Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube - Navigation bar components): Add missing resource for Cairo notification icon #2553

Closed
5 tasks done
inotia00 opened this issue Dec 16, 2024 · 1 comment
Closed
5 tasks done
Labels
Feature request Requesting a new feature

Comments

@inotia00
Copy link
Owner

inotia00 commented Dec 16, 2024

Application

YouTube

Feature description

This is not a feature request, but a description of the feature that will be introduce in the next release.

Google recently started implementing Cairo icons in the navigation bar, and this was widely rolled out in YouTube 19.28.42.

The problem is that some Cairo icons are missing.

A prime example is the notification icons in the navigation bar.

Since there is no Filled Cairo notification icon, the icon does not change when the user clicks on the Notifications tab in the navigation bar. ReVanced/revanced-patches#4046 (comment)

In fact, this is a bug that Google needs to fix.

Since it is not difficult to fix, I decided to include this in the next release.

The only problem is that I could not find a Filled Cairo notification icon anywhere, so I solved it by simply making a Filled Cairo notification icon as close as possible.

Motivation

More than five months after the Cairo navigation bar was widely rolled out, Google doesn't seem to have any intention of fixing the issue.

Acknowledgements

  • This is not a feature request for YouTube.
  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@inotia00 inotia00 added the Feature request Requesting a new feature label Dec 16, 2024
inotia00 added a commit to inotia00/revanced-patches that referenced this issue Dec 16, 2024
@inotia00
Copy link
Owner Author

reflected in revanced-patches-5.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature
Projects
None yet
Development

No branches or pull requests

1 participant