Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: (YouTube): Various Visual preference icons icons are missing #2129

Closed
5 tasks done
Rairof opened this issue Jun 11, 2024 · 5 comments
Closed
5 tasks done

bug: (YouTube): Various Visual preference icons icons are missing #2129

Rairof opened this issue Jun 11, 2024 · 5 comments
Labels
Bug report Something isn't working

Comments

@Rairof
Copy link

Rairof commented Jun 11, 2024

Type

Cosmetic

Tools used

RVX Manager

Application

YouTube v19.20.35
ReVanced Patches: 4.9.1-dev.1
ReVanced Integrations: 1.10.1-dev.1

Bug description

The newly added Visual preference icons patch seems to be missing quite a lot of icons on various other sections such as (YouTube/Shorts/Short player), (YouTube/Miscellaneous), specifically in (YouTube/Videos) section.

(YouTube/Videos) Various patch preference icons are missing-
Screenshot_20240611-055254
(YouTube/Shorts/Shorts player) Hide disabled comments button patch preference icon is missing-
Screenshot_20240611-055331
(YouTube/Miscellaneous) Enable debug buffer logging patch preference icon is missing-
Screenshot_20240611-055353

Error logs

N/A

Solution

Add relevant preference icons

Additional context

Maybe it's just an error with implementing the patch as there are the spaces for icons to be added in the said sections but no icons are set, or as it is a completely new patch and the visuals of Revanced extended settings seems to be overhauled (which I like btw thx inotia ♥️) these might be some sort of bug?

Device Environment

Android 14, pixelOS

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@Rairof Rairof added the Bug report Something isn't working label Jun 11, 2024
@vippium
Copy link

vippium commented Jun 11, 2024

They are not missing. They are not even created by anddea. So this is not an bug. Icons which are already there in anddea's repo are here

@Rairof
Copy link
Author

Rairof commented Jun 11, 2024

#2129 (comment)
I see, then maybe they might open a PR to this issue when then decide on adding those icons.

@Aryan-Chauhan
Copy link

Did you check if they exist in anddea's RVX or not?

@Rairof
Copy link
Author

Rairof commented Jun 11, 2024

#2129 (comment)
I haven't used anddea patches before so I haven't checked them.

@vippium
Copy link

vippium commented Jun 11, 2024

Did you check if they exist in anddea's RVX or not?

#2129 (comment) I didn't used anddea patches so I haven't checked them.

I use both rvx bro..so it is known to me. He is adding more in upcoming releases. Just wait for these icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants