suggestion (YT) : Integrate Change Header patch from ReVanced to ReVanced Extended.

[Aryan-Chauhan]

Application

YouTube

Suggestion description

Hello!

Kindly integrate the Change Header patch from ReVanced to ReVanced Extended.

Pull request link: ReVanced/revanced-patches#2512

Commit link: ReVanced/revanced-patches@75f785d

Thanks!

Acknowledgements

• This issue is not a duplicate of an existing suggestion.
• This is not a feature request.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• I have written the title and contents in English.

[inotia00]

High-resolution logo image is required to merge patches.

[Aryan-Chauhan]

High-resolution logo image is required to merge patches.

I cannot understand why high-resolution logo image is required to merge patches. Kindly explain if there is something that I'm not understanding.

I wasn't requesting for some preset headers.

I will make my own header design and provide the path to those PNGs in ReVancify's Edit Patch Options (this is what I currently do in anddea's RVX, because it has this patch). Just this patch is required for me, the headers I will design for myself.

[inotia00]

ReVanced also changes to the default header value if no configuration options are entered.
This is what I'm talking about.

This means that if no custom values are entered, the default values should be used, so you need a high-resolution custom header that supports all resolutions.

Additionally, a valid method that does not conflict with existing Change YouTube header settings should be provided.

Unless this is resolved, I have no plans to add it in a patch.

[n1cKz1]

Additionally, a valid method that does not conflict with existing Change YouTube header settings should be provided.

One way I can think for that to be resolved:

Perhaps since the premium header on YouTube is named differently than the original header (non premium is yt_wordmark_header and premium yt_premium_wordmark_header) the change header patch could be tweaked to also replace the premium header along with the non-premium header, and thus being able to switch between 2 custom headers (non-premium & premium) with the change YouTube header setting.

Of course this may be way more trouble than it's worth though.

[inotia00]

The default header value has been added as PR is merge.

If I add this with a new patch, there may be conflicts with the existing patch.

So, instead of adding a new patch, I will include it in the patch option of the Custom branding icon YouTube patch.

[inotia00]

reflected in revanced-patches-4.9.1-dev.1

[inotia00]

reflected in revanced-patches-4.9.1