feat(street-search): replace linkStreet sub-form with street select

[derrabauke]

This will resolve the required connection between locality and street for creating new buildings/entrances.

Added in locations

• create new building
• create new entrance

Preview

Disabled state

Enabled

Search

Selected

[derrabauke]

@kaldras @luytena ready for review

[luytena]

Looking good 👌 Do we still need the link-street route? Otherwise, we could remove it, I think. Also, did you get a chance to test it integrated in one of the ebau cantons?

[luytena]

@derrabauke Have you had time to take a look at the review comments?

[derrabauke]

at the review comments?

Will have a look today

[derrabauke]

@luytena please re-review

[derrabauke]

Looking good 👌 Do we still need the link-street route? Otherwise, we could remove it, I think. Also, did you get a chance to test it integrated in one of the ebau cantons?

Yes we still need the link-street route for editing existing entrances.

[luytena]

Looking good 👌 Do we still need the link-street route? Otherwise, we could remove it, I think. Also, did you get a chance to test it integrated in one of the ebau cantons?

Yes we still need the link-street route for editing existing entrances.

Mhh, is this because it uses a different request (modifyBuildingEntrance)? From a user perspective I think it would be nice to have the same interface everywhere. But I think we can discuss this if the need arises at a later point.

[luytena]

LGTM 🔥

[luytena]

@derrabauke Let's release it and test it integrated in eBau.

[luytena]

🎉 This PR is included in version 7.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀