Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing of entries between closure state 640 and 690 #462

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

velrest
Copy link
Contributor

@velrest velrest commented Jan 12, 2023

Revert #308 and #385

Due to a miscommunication, editing is actually allowed but discouraged.

@velrest velrest requested a review from luytena January 12, 2023 15:32
@velrest velrest force-pushed the fix-closure-editing branch from 583749c to 2ec7ec8 Compare January 12, 2023 15:57
@velrest velrest marked this pull request as ready for review January 12, 2023 15:59
@velrest velrest self-assigned this Jan 12, 2023
@velrest velrest force-pushed the fix-closure-editing branch 5 times, most recently from 9e7e6ba to b773c57 Compare January 13, 2023 15:38
@velrest velrest force-pushed the fix-closure-editing branch from b773c57 to fc7fffa Compare January 13, 2023 15:42
@velrest velrest merged commit fa40ab7 into inosca:main Jan 13, 2023
@luytena
Copy link
Contributor

luytena commented Jan 13, 2023

🎉 This PR is included in version 6.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

luytena added a commit to luytena/ember-ebau-gwr that referenced this pull request Mar 1, 2023
…arch route

Fixes indentation bug introduced in PR inosca#462.
luytena added a commit that referenced this pull request Mar 2, 2023
…arch route

Fixes indentation bug introduced in PR #462.
luytena pushed a commit that referenced this pull request Mar 2, 2023
## [6.3.5](v6.3.4...v6.3.5) (2023-03-02)

### Bug Fixes

* **intl:** improve fr translation of official construction project file no hint ([9e4ca5b](9e4ca5b))
* **linked-models:** ensure creation link is shown independently of search route ([847fe2e](847fe2e)), closes [#462](#462)
* **validations:** allow blank entries for official construction project file no ([1ae5fb3](1ae5fb3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants