Static compilation #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skymandr
approved these changes
May 19, 2020
There was a problem hiding this comment.
Looks good to me and - more importantly - solves my problems. Even though @local-minimum didn't have exactly the same problems, I suggest you merge this since it's fairly critical. If his problems persist, we can reopen the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #97 - VSC can build and test code.
Fixes some build/CI problems - "make lint" runs in CI in the same way as for users.
Golint version is specifically set in tools.go - i.e.
go mod tidycan run without removing golint dependency.