Buffered channels #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
local-minimum
approved these changes
May 15, 2020
skymandr
reviewed
May 15, 2020
internal/extractors/extract_data.go
Outdated
| @@ -9,13 +9,15 @@ import ( | |||
| // ExtractFunction is the type of the ExtractData function | |||
| type ExtractFunction func(callback common.Callback, streamBatch ...StreamBatch) | |||
|
|
|||
| const channelBufferSize int = 1000 | |||
There was a problem hiding this comment.
Nit-picking here, but are re there any cache chunk related reasons to think that 1024 might be better?
There was a problem hiding this comment.
OK, it looks better :)
|
@local-minimum: experimenting and guessing - yes, the application will use more heap - we're useing about 120Mb on my laptop (8cpus) |
|
Sorry guys I added one more optimization moved the image conversion into the go routine for encoding png. |
…into buffered-channels
local-minimum
requested changes
May 15, 2020
local-minimum
approved these changes
May 15, 2020
Co-authored-by: Martin Zackrisson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using buffered channels since I noticed that the go routings spends a lot of time waiting for synchronization between channels. The value 1000 is a educated guess since I know one picture is about ~2000 rac-records. Innosat channel seems to be the limiting channel.