Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified build triggering #74

Merged
merged 2 commits into from
May 13, 2020
Merged

modified build triggering #74

merged 2 commits into from
May 13, 2020

Conversation

BengtRydberg
Copy link
Contributor

Intention is that this should happen on push to any branch. And that no default merging
with master head is done. It is a bit difficult to test this.
The checkout is discussed here: actions/checkout#27

Resolves #38

modified build triggering. Intention is that this should
7d1430c 
happen on push to any branch. And that no default merging
with master head is done.
@BengtRydberg BengtRydberg requested a review from a team May 13, 2020 10:54
local-minimum
local-minimum approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@local-minimum local-minimum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and perhaps try a fake branch after that would work on its own but not against master? or if possible to see on the action log, to make sure it works as we wish

@BengtRydberg BengtRydberg merged commit 46d1158 into master May 13, 2020
@BengtRydberg BengtRydberg deleted the workflow_update branch May 13, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@local-minimum local-minimum local-minimum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Something is wrong with github CI
2 participants
@BengtRydberg @local-minimum