Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closing parenthesis erroneously included in hashtag #177

Open
FND opened this issue Jul 23, 2015 · 2 comments
Open

closing parenthesis erroneously included in hashtag #177

FND opened this issue Jul 23, 2015 · 2 comments

Comments

@FND
Copy link
Contributor

FND commented Jul 23, 2015

posting "lorem (ipsum #foo)" results in <a href=".../updates?query=%23foo%29">foo)</a> - surely that's almost always not what the user intended?
@mvitz
Copy link
Contributor

mvitz commented Jul 27, 2015

Thanks for reporting this (and sorry for answering that late).

Currently a tag (which is linked to when using the #) is defined as any character till the next whitespace occurrence. If we agree to change this we should discuss which characters to exclude because I think there would be many more candidates to exclude.

@FND
Copy link
Contributor Author

FND commented Jul 27, 2015

we should discuss which characters to exclude because I think there would be many more candidates to exclude

YAGNI? Users have a tendency to be hard to predict, so I'd rather fix bugs as they come up in real usage.

Having said that, I suppose punctuation ([.,!?:;"']) should be safe - though only if followed by whitespace (think "#foo:bar").

sorry for answering that late

How dare you take the weekend off!

mvitz added a commit that referenced this issue Oct 14, 2015
@mvitz
Use twitter for linking in updates
44c3ca4 
Using a well established standard for linking reduces discussions and
removes us from maintaing that logic as well.

Relates to #177
mvitz added a commit to mvitz/statuses that referenced this issue Mar 10, 2016
@mvitz
Use twitter for linking in updates
a82fa7d 
Using a well established standard for linking reduces discussions and
removes us from maintaing that logic as well.

Relates to innoq#177
mvitz added a commit to mvitz/statuses that referenced this issue Mar 10, 2016
@mvitz
Use twitter for linking in updates
b5d00ec 
Using a well established standard for linking reduces discussions and
removes us from maintaing that logic as well.

Relates to innoq#177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FND @mvitz