Report code loading problems into the resource action log #8749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,6 +79,21 @@ | |||
| environment. | |||
| """ | |||
|
|
|||
| """ | |||
Co-authored-by: Hugo-Inmanta <[email protected]>
Hugo-Inmanta
approved these changes
Feb 13, 2025
…inmanta/inmanta-core into issue/8722-report-code-loading-problems
wouterdb
approved these changes
Feb 17, 2025
|
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
Feb 17, 2025
…he resource action log. (Issue #8722, PR #8749) # Description * Fixed bug that caused code loading problems not to be reported into the resource action log. * Fixed bug where executor processes would remain hanging if a code loading problem occurs. * Fixed race condition in the `wait_until_deployment_finishes` method. closes #8722 # Self Check: - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [ ] ~~End user documentation is included or an issue is created for end-user documentation~~ - [ ] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
|
Merged into branches iso8, master in 9b7b2cb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wait_until_deployment_finishesmethod.closes #8722
Self Check:
End user documentation is included or an issue is created for end-user documentationIf this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)