Issue/3789 symmetric increments #3790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderr
approved these changes
Feb 8, 2022
arnaudsjs
approved these changes
Feb 9, 2022
|
I guess we have enough tests with this. |
|
Processing this pull request |
|
Pull request rejected by merge tool. The tests for this branch did not succeed. |
|
Processing this pull request |
|
Pull request rejected by merge tool. The tests for this branch did not succeed. |
|
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
Feb 9, 2022
…Issue #3789, PR #3790) # Description Fixes an issue where increments are not symmetric: the negative and positive part overlap, where it concerns event propagation This fix causes - slightly slower deploy due to more accurate (larger) increments - faster event response Does this require more testing? closes #3789 # Backstory The worst effect of this bug is in ISO5: Given: - Resource A on agent a - LifeCycleTransferResource on agent internal depends on A - Resource A is included in the increment by event (it is in the increment and in the negative increment) Scenario: - When agent a pulls A - resource A is marked as 'deployed because of known good state' (due to the negative increment) - resource A is returned to be deployed, because it is in the increment - resource A is marked as deploying - the state transfer - starts to execute, because all resources are in a deployed state - pulls the state of A when beginning the deploy - get deploying for A (this is a race with the above) - skips and hangs for a while # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
|
Merged into branches master, iso5 in 788f0f5 |
sanderr
pushed a commit
that referenced
this pull request
Feb 10, 2022
…Issue #3789, PR #3790) # Description Fixes an issue where increments are not symmetric: the negative and positive part overlap, where it concerns event propagation This fix causes - slightly slower deploy due to more accurate (larger) increments - faster event response Does this require more testing? closes #3789 # Backstory The worst effect of this bug is in ISO5: Given: - Resource A on agent a - LifeCycleTransferResource on agent internal depends on A - Resource A is included in the increment by event (it is in the increment and in the negative increment) Scenario: - When agent a pulls A - resource A is marked as 'deployed because of known good state' (due to the negative increment) - resource A is returned to be deployed, because it is in the increment - resource A is marked as deploying - the state transfer - starts to execute, because all resources are in a deployed state - pulls the state of A when beginning the deploy - get deploying for A (this is a race with the above) - skips and hangs for a while # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] Attached issue to pull request - [x] Changelog entry - [x] Type annotations are present - [x] Code is clear and sufficiently documented - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] Sufficient test cases (reproduces the bug/tests the requested feature) - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where increments are not symmetric: the negative and positive part overlap, where it concerns event propagation
This fix causes
Does this require more testing?
closes #3789
Backstory
The worst effect of this bug is in ISO5:
Given:
Scenario:
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box