Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dcoument configurable logging #8493

Closed
wouterdb opened this issue Dec 18, 2024 · 0 comments
Closed

Dcoument configurable logging #8493

wouterdb opened this issue Dec 18, 2024 · 0 comments
Assignees

Comments

@wouterdb
Copy link
Contributor

No description provided.

@wouterdb wouterdb self-assigned this Dec 18, 2024
inmantaci pushed a commit that referenced this issue Dec 19, 2024
# Description

Add configurable logging.

closes #8306
closes #8307

closes #8356

## includes
1. per-component log files via the config file
```ini
[logging]
server = server_log.yml
scheduler = scheduler.log.tmpl
```
2. tool to dump log file ` inmanta print_default_logging_config [compiler|scheduler|server]`
3. moved resource action log to scheduler

## Questions and results
1. [x] do we want comments in the files outputted by the tool?
           - comments are in the files in misc, not in the tool output
3. [x] do we want to enforce a naming convention on the logger. (it is in the code, but I wouldn't, as we don't have a lot of feeling with this )
         - no: we don't know logging well enogu
5. [x] should `-v` work when using the config file?
          - force in a cli logger at this level

## Next steps

1. [ ] remove all resource action alike functions from the server
2. [ ] add a way to validate config files for specific tools (like scheduler) -> #8482
6. [ ] Some methods in the stable api of the logging are deprecated, do we drop them? -> #8485
7. [ ] Hook on LSM  #8492
8. [ ] TTY forcing? -> #8484
9. [ ] load config from env var -> #8308
10. [ ] document logging config -> #8493

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) -> #8493
- [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant