Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error reporting on invalid V2 Modules #3797

Closed
wouterdb opened this issue Feb 9, 2022 · 0 comments
Closed

Improve error reporting on invalid V2 Modules #3797

wouterdb opened this issue Feb 9, 2022 · 0 comments
Assignees
@wouterdb

Comments

@wouterdb
Copy link
Contributor

wouterdb commented Feb 9, 2022

  • Currently, the name of the module is not part of the error
  • The error can occur when symlinking the plugins folder under test test folder to be able to load code in V1 module as if it was a V2 module. Nothing in the error gives any indication of this.
@wouterdb wouterdb self-assigned this Feb 9, 2022
This was referenced Feb 9, 2022
Closed
Closed
sanderr pushed a commit that referenced this issue Feb 10, 2022
@wouterdb @sanderr
Improved error reporting on malformed v2 module (Issue #3797, PR #3799)
99320bd 
# Description

Improved error reporting on malformed v2 module

closes #3797

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [x] Attached issue to pull request
- [x] Changelog entry
- [x] Type annotations are present
- [x] Code is clear and sufficiently documented
- [x] No (preventable) type errors (check using make mypy or make mypy-diff)
- [x] Sufficient test cases (reproduces the bug/tests the requested feature)
- [x] Correct, in line with design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wouterdb wouterdb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved error message inmanta/inmanta-core
1 participant
@wouterdb