Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sign-up): Add new optional params for sign-up flow #18

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

b0rba
Copy link
Contributor

@b0rba b0rba commented Jan 13, 2023

Accept external_id, policy_id, and account_id as optional params on the sign-up flow.

@b0rba b0rba self-assigned this Jan 13, 2023
@b0rba b0rba requested a review from a team as a code owner January 13, 2023 13:25
'address_coordinates': address_coordinates,
'external_id': external_id,
'policy_id': policy_id,
'account_id': account_id
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about writing a test, wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a test, with the address information also ;)

@b0rba b0rba requested a review from ottony January 13, 2023 16:50
@b0rba b0rba merged commit 859eaa9 into main Jan 13, 2023
@gaabs gaabs deleted the feature/register-sign-up-optional-params branch January 16, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants