Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove deprecated timestamp fields #238

Open
wants to merge 1 commit into
base: fix-feedback-remove-invalid-types
Choose a base branch
from
Open

feat!: remove deprecated timestamp fields #238

wants to merge 1 commit into from

Conversation

figueredo
Copy link
Contributor

Proposed changes

Removes deprecated timestamp fields. They are being replacted by occurred_at (Feedback) and collected_at (Additional Location)

Checklist

  • Style check and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@figueredo figueredo requested a review from racevedoo July 24, 2024 19:01
@figueredo figueredo self-assigned this Jul 24, 2024
@figueredo figueredo requested a review from a team as a code owner July 24, 2024 19:01
@figueredo figueredo requested a review from gaabs July 24, 2024 19:01
@figueredo figueredo changed the base branch from master to fix-feedback-remove-invalid-types July 24, 2024 19:01
@figueredo figueredo changed the title Feat remove deprecated timestamp feat!: remove deprecated timestamp fields Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racevedoo racevedoo racevedoo approved these changes

@gaabs gaabs Awaiting requested review from gaabs gaabs is a code owner automatically assigned from inloco/incognia-owners

Assignees

@figueredo figueredo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@figueredo @racevedoo