Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to pass feedback event type as string #235

Open
wants to merge 1 commit into
base: rfc3339-fields
Choose a base branch
from
Open

feat: allow to pass feedback event type as string #235

wants to merge 1 commit into from

Conversation

figueredo
Copy link
Contributor

Proposed changes

Allows passing the feedback event type as a string to support custom feedback types.

Checklist

  • Style check and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@figueredo figueredo requested a review from racevedoo July 17, 2024 18:23
@figueredo figueredo self-assigned this Jul 17, 2024
@figueredo figueredo requested a review from a team as a code owner July 17, 2024 18:23
@figueredo figueredo requested review from gaabs and removed request for a team July 17, 2024 18:23
@figueredo figueredo force-pushed the fix-feedback-remove-invalid-types branch from deedcf3 to ae0e4e4 Compare July 18, 2024 00:07
@figueredo figueredo force-pushed the feat-feedback-event-as-string branch from 1cff117 to 65649b8 Compare July 18, 2024 00:08
@figueredo figueredo changed the base branch from fix-feedback-remove-invalid-types to rfc3339-fields July 19, 2024 20:05
@figueredo figueredo force-pushed the feat-feedback-event-as-string branch from 65649b8 to 416299d Compare July 19, 2024 20:05
@figueredo figueredo force-pushed the rfc3339-fields branch 2 times, most recently from 7b4e6d8 to 43ff19b Compare July 24, 2024 18:05
@figueredo figueredo force-pushed the feat-feedback-event-as-string branch from 416299d to 977a2ba Compare July 24, 2024 18:20
@figueredo figueredo force-pushed the feat-feedback-event-as-string branch from 977a2ba to 38f2459 Compare July 24, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racevedoo racevedoo racevedoo approved these changes

@gaabs gaabs Awaiting requested review from gaabs gaabs is a code owner automatically assigned from inloco/incognia-owners

Assignees

@figueredo figueredo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@figueredo @racevedoo