Support web login #183
Merged
Support web login #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangalvino
approved these changes
Nov 17, 2023
ebaf
approved these changes
Nov 17, 2023
| public TransactionAssessment registerWebLogin(RegisterWebLoginRequest request) | ||
| throws IncogniaException { | ||
| Asserts.assertNotNull(request, "register login request"); | ||
| Asserts.assertNotEmpty(request.getInstallationId(), "installation id"); |
There was a problem hiding this comment.
isso aq n ta errado? o installation id tem que ser null no web
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support web login via a new method:
registerWebLogin, following the api design of our Node client.Checklist