Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/error handling #185

Merged
merged 24 commits into from
Sep 25, 2023
Merged

Feature/error handling #185

merged 24 commits into from
Sep 25, 2023

Conversation

codespool
Copy link
Collaborator

  • improve command inheritance
  • add modern-errors lib for error handling
  • adds winston logger for cli error and file logging
  • correctly handle rejected promises as errors

codespool added 22 commits July 18, 2023 16:40
@codespool
update all commands to inherit SwankyCommand
c7467b2
@codespool
move ensureSwanky.. behaviour to swankyCommand
cc04769
@codespool
cleanup
32643d5
@codespool
update deps/fix vulnerabilities
6893240
@codespool
update eslint config with type checks
f6862f4
@codespool
update deps
d4ca9c8
@codespool
update oclif
cc0e352
@codespool
update polkadot deps
dd80a47
@codespool
add top level error handler
0c5923f
@codespool
update generic types of child classes
d11c7b1
@codespool
extract errors and logger to own files
de50962
@codespool
add apiPromise creation as promise
771e420
@codespool
move DeployApi into parent class
07ce4ac
@codespool
correctly throw json error
b482998
@codespool
implement process error
ddf862f
@codespool
handle provider and api events with promises
e4793d8
@codespool
replace generic with standard errors
342d908
@codespool
add proper error classes
6f7c2ea
@codespool
convert oclif error to modern-errors
8e4261e
@codespool
add initial info to log
4bc5741
@codespool
add compile logs
651748c
@codespool
3.1.0-beta.0
9153ae7
codespool
codespool commented Sep 25, 2023
View reviewed changes
Copy link
Collaborator Author

@codespool codespool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review - OK

@codespool codespool merged commit 4578921 into master Sep 25, 2023
@codespool codespool deleted the feature/error-handling branch September 25, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreOssun PierreOssun PierreOssun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codespool @PierreOssun