-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-contract call tracing #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments. In general, code looks confusing (which in Substrate usually means good) but the example usage (test) is not very useful.
|
||
struct TestDebugger; | ||
impl DebugExtT for TestDebugger { | ||
fn after_call( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to see a test where DebugExtT::after_call
is used to extract some data from the after_call
trace (and before_call
as well) which is then used to make some assertions in the unit test itself. I think an example like that would be far more useful for future users of this tracing feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would require interpreting Value
s from input_data
:|
We make use of the recent extension to pallet-contracts, which enables tracing cross-contract calls.