[IMP] crm_timesheet: Tell the user no running line was found

Imagine this scenario:

1. In tab 1 of the browser, you have opened lead 1.
2. In tab 2 of the browser, you have opened lead 2.
3. You go to tab 1 and start a timer.
4. Work, work, work...
5. You go to tab 2 and start a timer, stopping that of lead 1.
6. Work, work, work...
7. You go to tab 1 and see that timer as running (it is not, but you didn't refresh). You hit stop.

Before this commit, it just seemed like the timer was actually stopped. What did happen behind the scenes is that your view was refreshed, but no timer was touched fortunately.

After this commit, you get a message telling you that there's no timer to stop and that your browser is most likely out of sync. This mimics the behavior previously found when doing the same, but directly in the AAL. Now it's present in leads too.

crm_timesheet/models/crm_lead.py

@@ -4,6 +4,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
 from odoo import _, api, fields, models
+from odoo.exceptions import UserError
 
 
 class CrmLead(models.Model):
@@ -68,4 +69,9 @@ def button_end_work(self):
         running_lines = self.env["account.analytic.line"].search(
             self._timesheet_running_domain(),
         )
+        if not running_lines:
+            raise UserError(
+                _("No running timer found in lead/opportunity %s. "
+                  "Refresh the page and check again.") % self.display_name,
+            )
         return running_lines.button_end_work()

crm_timesheet/tests/test_account_analytic_line.py

@@ -2,6 +2,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 from datetime import date, datetime, timedelta
+from odoo import exceptions
 from odoo.tests.common import SavepointCase
 
 
@@ -73,6 +74,9 @@ def test_lead_time_control_flow(self):
         # Running line found, stop the timer
         self.assertEqual(self.lead.show_time_control, "stop")
         self.lead.button_end_work()
+        # No more running lines, cannot stop again
+        with self.assertRaises(exceptions.UserError):
+            self.lead.button_end_work()
         # All lines stopped, start new one
         self.lead.invalidate_cache()
         self.assertEqual(self.lead.show_time_control, "start")