Skip to content

Commit

Permalink
PS-8747: FEDERATED engine not handling wait_timeout (percona#5058)
Browse files Browse the repository at this point in the history
https://jira.percona.com/browse/PS-8747

Post push fix.
Scenario which needs debug facility moved to federated_debug.test

(cherry picked from commit 9468fd1)
  • Loading branch information
kamil-holubicki authored and inikep committed Jul 18, 2023
1 parent 8b6d0de commit b07b482
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
6 changes: 0 additions & 6 deletions mysql-test/suite/federated/r/federated.result
Original file line number Diff line number Diff line change
Expand Up @@ -2446,7 +2446,6 @@ DROP TABLE federated.t1;
DROP TABLE federated.t1;
#
# Bug#105878: PS-7999: FEDERATED engine not reconnecting on wait_timeout exceeded
# PS-8747: Got an error writing communication packets error during FEDERATED engine reconnection
#
SET @OLD_SLAVE_WAIT_TIMEOUT= @@GLOBAL.WAIT_TIMEOUT;
SET @@GLOBAL.WAIT_TIMEOUT= 4;
Expand All @@ -2468,11 +2467,6 @@ sleep(5)
SELECT * from test.t1;
id
1
SET @debug_save= @@GLOBAL.DEBUG;
DELETE FROM test.t1;
SET @@GLOBAL.DEBUG='+d,PS-8747_wait_for_disconnect_after_check';
INSERT INTO test.t1 SELECT tt.* FROM SEQUENCE_TABLE(20000) AS tt;
SET GLOBAL DEBUG= @debug_save;
DROP TABLE test.t1;
DROP SERVER test;
DROP TABLE test.t1;
Expand Down
12 changes: 0 additions & 12 deletions mysql-test/suite/federated/t/federated.test
Original file line number Diff line number Diff line change
Expand Up @@ -2152,7 +2152,6 @@ DROP TABLE federated.t1;

--echo #
--echo # Bug#105878: PS-7999: FEDERATED engine not reconnecting on wait_timeout exceeded
--echo # PS-8747: Got an error writing communication packets error during FEDERATED engine reconnection
--echo #
connection slave;
SET @OLD_SLAVE_WAIT_TIMEOUT= @@GLOBAL.WAIT_TIMEOUT;
Expand All @@ -2170,21 +2169,10 @@ eval CREATE SERVER test FOREIGN DATA WRAPPER test1 OPTIONS(
database 'test');
CREATE TABLE test.t1 (id int PRIMARY KEY) ENGINE=FEDERATED CONNECTION='test';

# scenario 1: PS-7999
SELECT * FROM test.t1;
SELECT sleep(5);
SELECT * from test.t1;

# scenario 2: PS-8747
SET @debug_save= @@GLOBAL.DEBUG;
DELETE FROM test.t1;
SET @@GLOBAL.DEBUG='+d,PS-8747_wait_for_disconnect_after_check';

# Send data which will not fit into one communication packet, so client will try to send them
# before flush and reconnection.
INSERT INTO test.t1 SELECT tt.* FROM SEQUENCE_TABLE(20000) AS tt;
SET GLOBAL DEBUG= @debug_save;

DROP TABLE test.t1;
DROP SERVER test;
connection slave;
Expand Down

0 comments on commit b07b482

Please sign in to comment.