-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh the Travis scripts to test more distros and targets #94
Conversation
I've also been looking at this, so thanks for getting it started. I think I'm of the opinion that we should gut most of the matrix. I would say only test on ubuntu, only specify |
d0150fd
to
d8e5962
Compare
- Instead of hardcoding versions, the opam2 Docker images now have aliases to the latest versions of the OS, so use those. - Remove the patch version from the compiler version, so the latest is always used. - Build all the targets to ensure examples work (fixes inhabitedtype#93)
I'm attempting to use `make` here since it mirrors the typical development workflow and also lets you specify multiple actions easily.
67f6699
to
7f97a38
Compare
Instead of this giant matrix, we're going to focus on a single linux distro and a few versions of OCaml, and for each one we can install all 3 packages and also use our `Makefile` rules to build the examples. It's possible that I don't completely understand the tradeoffs of doing it this way, but we should at least have much more reasonable build times.
7f97a38
to
76fd166
Compare
After a few attempts I believe I have pleased the I realize now that I somewhat hijacked this PR and we are now testing fewer distros, but if this seems like a suitable path forward I can merge it tomorrow. |
- PACKAGE="httpaf-lwt" DISTRO="debian-unstable" OCAML_VERSION="4.03.0" | ||
- OCAML_VERSION="4.07" | ||
- OCAML_VERSION="4.06" | ||
- OCAML_VERSION="4.05" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, but I'd recommend you also add OCAML_VERSION=4.04
and 4.03
lines as well, since that's what the opam file advertises as supported versions. There aren't any C bindings or anything in this, so the multiple distros won't matter much and will be tested in opam-repository when released.
We can add the other OCaml compiler versions in another PR if needed. |
have aliases to the latest versions of the OS, so use those.
latest is always used.