Fix "input shrunk" bug #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the parser has been fed input but has not hit a commit point so the entire buffer can be consumed, a subseqent report_exn call will result in the parser raising with the message "input shrunk". This is a requirement of angstrom. After it sees some input, you can't take it away. Fixed in a subsequent commt.
When the parser is forced-closed, make the next call to `next` report close. This will give the caller the opportunity to feed the parser the final bytes available (or to not) before everything shuts down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the parser has been fed input but has not hit a commit point so the entire buffer can be consumed, a subsequent
report_exncall will result in the parser raising with the message "input shrunk".The fix is to not feed any input to the parser when it is force-closed, but instead make the next call to
nextreport close. This will give the caller the opportunity to feed the parser the final bytes available (or to not) before everything shuts down.