rm-client-sim: port client simulator test to unit tests, fix last chunk parse bug #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client connection currently works with a well-behaving runtime. However, it needlessly requests a yield in order to shutdown the writer. This isn't to expensive, and it makes testing easier.
The last chunk of a chunk-encoded body was not being properly parsed. Specifically, the final eol was not being consumed. This is the other side of the same coin fixed in #106.
seliopou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the last of the simulator tests over to unit tests. Fix a bug in parsing the final chunk in a chunk-encoded body. The final eof wasn't being consumed.