unset yield on flush #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you ask a serializer to `yield`, then synchronously use it in such a way that you no longer want it to yield, there is no way to "undo" the yield aside from using `operation` twice and ignoring the first yield. The semantics of `flush` should be that it unsets any possible `yield` flag so that the next operation has a chance to read pending iovecs. I did not include tests, particularly because this was difficult to encapsulate with the given framework. We need to be able to inspect the state of the serializer without closing it, and all current serialize functions do close it in order to dump the contents to a string or bigstring.
dpatti
added a commit
to dpatti/httpaf
that referenced
this pull request
Jul 16, 2018
This test exposes an issue where a response hangs indefinitely because `respond_with_streaming` puts the writer into `yield` mode so that it doesn't write until the first `flush`, but if the first `flush` call happens before the write loop "exhausts" the yield, it will just get stuck. This requires a change in Faraday [1] to fix. [1]: inhabitedtype/faraday#44
seliopou
added a commit
that referenced
this pull request
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you ask a serializer to
yield, then synchronously use it in such away that you no longer want it to yield, there is no way to "undo" the
yield aside from using
operationtwice and ignoring the first yield.The semantics of
flushshould be that it unsets any possibleyieldflag so that the next operation has a chance to read pending iovecs.
I did not include tests, particularly because this was difficult to
encapsulate with the given framework. We need to be able to inspect the
state of the serializer without closing it, and all current serialize
functions do close it in order to dump the contents to a string or
bigstring.