Allow work with CSE on user-mode (issue #36) #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbanos
requested changes
Apr 24, 2020
Comment on lines
108
to
120
| func (csets *CloudSpecificExtensionDeploymentService) DeleteDeployment(deploymentID string) (err error) { | ||
| log.Debug("DeleteDeployment") | ||
|
|
||
| data, status, err := csets.concertoService.Delete(fmt.Sprintf("/cse/deployments/%s", deploymentID)) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if err = utils.CheckStandardStatus(status, data); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
Deleting a CSE deployment just starts the undeploy process: you should return here a representation parsed from the response
| } | ||
|
|
||
| // CreateTemplate creates a cloud specific extension template | ||
| func (csets *CloudSpecificExtensionTemplateService) CreateTemplate(templateVector *map[string]interface{}) (template *types.CloudSpecificExtensionTemplate, err error) { |
There was a problem hiding this comment.
templateVector is a bad name, what about templateParams?
There was a problem hiding this comment.
Done, additionally this should be done in more cases (added a note at issue #31 ).
Comment on lines
156
to
173
| func CloudSpecificExtensionDeploymentDelete(c *cli.Context) error { | ||
| debugCmdFuncInfo(c) | ||
| svc, formatter := WireUpCloudSpecificExtensionDeployment(c) | ||
|
|
||
| checkRequiredFlags(c, []string{"id"}, formatter) | ||
| err := svc.DeleteDeployment(c.String("id")) | ||
| if err != nil { | ||
| formatter.PrintFatal("Couldn't delete CSE deployment", err) | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
You should probably show here the CSED as decommissioning
- Additionally, rename parameters Closes #36
pcantera
force-pushed
the
feature/36-allow-work-cse
branch
from
2766a92
to
c9b9681
Compare
chris-m-h
approved these changes
May 6, 2020
pbanos
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Cloud Specific Extension commands:
cio cloud-specific-extensions templates :
list > Lists List CSE templates
GET /v2/cse/templates
show -> Shows CSE template
GET /v2/cse/templates/:template_id
import -> Imports a CSE template
POST /v2/cse/templates
update -> Updates an existing CSE template identified by the given id
PUT /v2/cse/templates/:template_id
list-deployments -> List CSE deployments of a CSE template
GET /v2/cse/templates/:template_id/deployments
delete -> Deletes a CSE template
DELETE /v2/cse/templates/:template_id
cio cloud-specific-extensions deployments :
list > Lists List CSE deployments
GET /v2/cse/deployments
show -> Shows CSE deployment
GET /v2/cse/deployments/:deployment_id
deploy -> Deploys a new CSE deployment from CSE template
POST /v2/cse/templates/:template_id/deployments
update -> Updates an existing CSE deployment identified by the given id
PUT /v2/cse/deployments/:deployment_id
delete -> Deletes a CSE deployment
DELETE /v2/cse/deployments/:deployment_id
Description
Related Issue
Closes #36
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate)
Types of changes
Checklist