Test Merkle-tree padding for all device #668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koren-Brand
reviewed
Nov 28, 2024
icicle/tests/test_hash_api.cpp
Outdated
|
|
||
| const unsigned nof_leaves_in_hash = layer0_hash.default_input_chunk_size() / leaf_size; | ||
|
|
||
| ICICLE_LOG_VERBOSE << "19 hashes (Total hashes in layer 0 - 1) - full"; |
There was a problem hiding this comment.
Can you remove the 19 here? the changes made in the tree above now yield 100 hashes in the lowest level instead of the previous 20.
There was a problem hiding this comment.
I refined the tests. Seems like there is a lot of redundancy
Koren-Brand
reviewed
Nov 28, 2024
icicle/tests/test_hash_api.cpp
Outdated
|
|
||
| const unsigned nof_leaves_in_hash = layer0_hash.default_input_chunk_size() / leaf_size; | ||
|
|
||
| ICICLE_LOG_VERBOSE << "19 hashes (Total hashes in layer 0 - 1) - full"; |
There was a problem hiding this comment.
Same here - remove 19 and keep the text in the parenthesis.
yshekel
force-pushed
the
yshekel/test_merkel_padding
branch
from
ad0b3a3
to
bcd56cf
Compare
yshekel
force-pushed
the
yshekel/test_merkel_padding
branch
from
bcd56cf
to
9de4831
Compare
Koren-Brand
reviewed
Nov 28, 2024
| int output_store_min_layer = 0; | ||
| constexpr int leaf_size = 250; | ||
| constexpr int nof_leaves = 100; | ||
| const std::vector<int> test_cases_nof_input_leaves = {1, 8, 32, |
There was a problem hiding this comment.
Add 16 and 17 (or just add 33) to test edge cases in the CPU given the chunk size of 16 when building the tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuda-backend-branch: emir/merkle-padding