[FEAT] ReleaseDomain API #465
Conversation
| where | ||
| <F as FieldImpl>::Config: NTT<F>, | ||
| { | ||
| // let ctx = DeviceContext::default_for_device(device_id); |
| @@ -201,6 +201,11 @@ func TestNttBatch(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestReleaseDomain(t *testing.T) { | |||
| cfg := GetDefaultNttConfig() | |||
| ReleaseDomain(cfg.Ctx) | |||
There was a problem hiding this comment.
I think that ideally the test should release an allocated domain, call NTT and assert the error. Having said that I am not sure this can be achieved in go since the exception cannot be caught here I guess.
My issue with this test is that it passes even if ReleaseDomain() is doing nothing or behaves wrong.
There was a problem hiding this comment.
I think that ideally the test should release an allocated domain, call NTT and assert the error.
It should be possible to assert.Panics(Ntt()) after releasing the domain.
| @@ -27,6 +30,13 @@ where | |||
| } | |||
| } | |||
|
|
|||
| pub fn rel_domain<F: FieldImpl>(ctx: &DeviceContext) | |||
There was a problem hiding this comment.
if this is the exposed API I would rename to release_domain
There was a problem hiding this comment.
Its a test function so I think the naming is fine but it doesn't need to be public since it is only being used in https://github.com/ingonyama-zk/icicle/pull/465/files#diff-96ad6a0ca42317faaf6524296cdaa92fcc3c634d36e2882c2b322d9b7287fd84R378
## Describe the changes This PR adds a NTT ReleaseDomain API in Golang and Rust ## Linked Issues Resolves # --------- Co-authored-by: Yuval Shekel <[email protected]>
## Describe the changes This PR adds a NTT ReleaseDomain API in Golang and Rust ## Linked Issues Resolves # --------- Co-authored-by: Yuval Shekel <[email protected]>
Describe the changes
This PR adds a NTT ReleaseDomain API in Golang and Rust
Linked Issues
Resolves #