Pedersen commitment example in c++ #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #include <cassert> | ||
| #include <nvml.h> | ||
|
|
||
| #define CURVE_ID 1 |
There was a problem hiding this comment.
You can use
#define CURVE_ID BN254
This is much more readable
There was a problem hiding this comment.
Also, would be great to change it in all examples
| set(CMAKE_CUDA_FLAGS_RELEASE "") | ||
| set(CMAKE_CUDA_FLAGS_DEBUG "${CMAKE_CUDA_FLAGS_DEBUG} -g -G -O0") | ||
| # change the path to your Icicle location | ||
| include_directories("../../../icicle") |
There was a problem hiding this comment.
This isn't specific to this example but it would be good to compile ICICLE once for all of the c++ examples and use target_link_libraries to link icicle. It would reduce the CI time significantly
Co-authored-by: Jeremy Felder <[email protected]>
jeremyfelder
approved these changes
Feb 28, 2024
omershlo
reviewed
Feb 28, 2024
| ## What's in the example | ||
|
|
||
| 1. Define the curve and the size of commitment vector | ||
| 2. Use public random seed to transparently generate elliptic points without known discrete logarithm |
There was a problem hiding this comment.
suggested rewrite: points on the elliptic curve
There was a problem hiding this comment.
Thanks! Corrected.
Merged
jeremyfelder
added a commit
that referenced
this pull request
Feb 28, 2024
* initial commit * random elliptic points * initial complete example * public random seed to prevent knowing dlogs * cleaned up code * add README * Update examples/c++/pedersen-commitment/README.md Co-authored-by: Jeremy Felder <[email protected]> * updates to PR comments * codespell compliance * corrected terminology in README --------- Co-authored-by: Jeremy Felder <[email protected]>
jeremyfelder
added a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Show using Icicle's MSM to perform Pedersen commitment