updates example compares Radix2 and MixedRadix NTTs #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
reviewed
Feb 19, 2024
examples/c++/ntt/README.md
Outdated
| 1. Define the size of the example | ||
| 2. Initialize input | ||
| 3. Run Radix2 NTT | ||
| 4. Run MexedRadix NTT |
yshekel
reviewed
Feb 19, 2024
examples/c++/ntt/example.cu
Outdated
| int main(int argc, char* argv[]) | ||
| { | ||
| std::cout << "Icicle Examples: Number Theoretical Transform (NTT)" << std::endl; | ||
| std::cout << "Example parameters" << std::endl; | ||
| const unsigned log_ntt_size = 20; | ||
| const unsigned log_ntt_size = 26; |
There was a problem hiding this comment.
note that some CI machines may not have enough memory for that.
There was a problem hiding this comment.
@svpolonsky You can add the "examples" label here and it will run on a specific machine
There was a problem hiding this comment.
I'd rather keep things simple and use log_ntt_size = 20
yshekel
reviewed
Feb 19, 2024
| err = NTT<S, E>(input, ntt_size, NTTDir::kForward, config, output); | ||
| END_TIMER(Radix2, "Radix2 NTT"); | ||
|
|
||
| std::cout << "Validating output" << std::endl; | ||
| validate_output(ntt_size, nof_ntts, output); |
There was a problem hiding this comment.
what is being validate here? note that radix2 is overriding the mixed-radix output
There was a problem hiding this comment.
Thanks for pointing this out, I'll run validate twice for both ntt calls
jeremyfelder
approved these changes
Feb 20, 2024
Merged
jeremyfelder
added a commit
that referenced
this pull request
Feb 23, 2024
# Contents of this release Examples: multi-gpu example #381 Examples: updates example compares Radix2 and MixedRadix NTTs #383 Feat: add vector operations bindings to Rust #384 Examples: update examples with new vec ops #388 Feat: Grumpkin curve implementation #379 Feat: mixed-radix NTT fast twiddles mode #382 Docs: Update README.md #385 #387 README: Update Hall of Fame section #394 Examples: add rust poseidon example #392 Feat: GoLang bindings for v1.x #386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Update to cover new NTT algorithms