Feature/api formbackend management #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ich habe einen Issue bei dw aufgemacht und versuche ein Workaround zu implementieren: dropwizard/dropwizard#9612 |
awildturtok
reviewed
Nov 11, 2024
Comment on lines
19
to
24
| try { | ||
| managerNode.getFormScanner().execute(null, null); | ||
| } | ||
| catch (Exception e) { | ||
| throw new RuntimeException(e); | ||
| } |
| // Workaround to remove metrics (see https://github.com/dropwizard/dropwizard/issues/9612) | ||
| ConfiguredCloseableHttpClient internalHttpClient = conqueryClientBuilder.getHttpClient(); | ||
| if (internalHttpClient != null) { | ||
| internalHttpClient.getClient().close(); |
There was a problem hiding this comment.
frage mich hier ob du damit nicht alle clients schließt?
There was a problem hiding this comment.
Der InterneClient ist exclusiv für jeden JerseyClient, den man Instanziiert
| @@ -9,4 +9,6 @@ | |||
| public interface PluginConfig { | |||
|
|
|||
| default void initialize(ManagerNode managerNode){} | |||
|
|
|||
| default void deinitialize(){} | |||
awildturtok
approved these changes
Nov 11, 2024
| <goal>generate</goal> | ||
| </goals> | ||
| <configuration> | ||
| <inputSpec>${project.basedir}/src/main/resources/openapi/admin-openapi.json</inputSpec> |
There was a problem hiding this comment.
wo benutzt du die Klassen die hiermit konfiguriert werden?
There was a problem hiding this comment.
Es wird dieses Interface generiert:
/**
* Represents a collection of functions to interact with the API endpoints.
*/
@Path("/config/plugins/form-backend")
@Api(description = "the config API")
@jakarta.annotation.Generated(value = "org.openapitools.codegen.languages.JavaJAXRSSpecServerCodegen", date = "2024-11-08T16:19:10.432789300+01:00[Europe/Berlin]", comments = "Generator version: 7.9.0")
public interface ConfigApi {
/**
*
*
* @param configId
* @return successful operation
*/
@DELETE
@Path("/{configId}")
@Produces({ "*/*" })
@ApiOperation(value = "unegister form backend configuration", notes = "", tags={ "plugin" })
@ApiResponses(value = {
@ApiResponse(code = 200, message = "successful operation", response = String.class) })
String deleteFormBackend(@PathParam("configId") String configId);
/**
*
*
* @return successful operation
*/
@GET
@Produces({ "application/json" })
@ApiOperation(value = "lists all registered form backend configurations", notes = "", tags={ "plugin" })
@ApiResponses(value = {
@ApiResponse(code = 200, message = "successful operation", response = String.class, responseContainer = "List") })
List<String> listFormBackends();
/**
*
*
* @param pluginConfig
* @return successful operation
*/
@POST
@Consumes({ "application/json" })
@Produces({ "application/json" })
@ApiOperation(value = "adds a form backend configurations", notes = "", tags={ "plugin" })
@ApiResponses(value = {
@ApiResponse(code = 200, message = "successful operation", response = String.class) })
String registerFormBackend(@Valid @NotNull FormBackendConfig pluginConfig);
}Und ich habe es hiermit implementiert backend/src/main/java/com/bakdata/conquery/resources/admin/rest/ConfigApiResource.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses openapi spec to define endpoints