show warning in ui if user or role could not be resolved #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thoniTUB
commented
Oct 7, 2024
•
thoniTUB
commented
|
@awildturtok ich musste einige dateien anfassen, aber der pr ist durch das methoden sortieren so groß geworden |
awildturtok
approved these changes
Oct 8, 2024
| } | ||
| return name; | ||
| } | ||
| catch (java.text.ParseException e) { |
There was a problem hiding this comment.
In der Klasse gibt leider zwei unterschiedliche mit selben namen
Comment on lines
+74
to
76
| public Response deleteRoleFromUser(@PathParam(GROUP_ID) Group group, @PathParam(ROLE_ID) RoleId role) { | ||
| processor.deleteRoleFrom(group, role); | ||
| return Response.ok().build(); |
There was a problem hiding this comment.
Suggested change
| public Response deleteRoleFromUser(@PathParam(GROUP_ID) Group group, @PathParam(ROLE_ID) RoleId role) { | |
| processor.deleteRoleFrom(group, role); | |
| return Response.ok().build(); | |
| public void deleteRoleFromUser(@PathParam(GROUP_ID) Group group, @PathParam(ROLE_ID) RoleId role) { | |
| processor.deleteRoleFrom(group, role); |
Comment on lines
+67
to
69
| public Response deleteUserFromGroup(@PathParam(GROUP_ID) Group group, @PathParam(USER_ID) UserId user) { | ||
| processor.deleteUserFromGroup(group, user); | ||
| return Response.ok().build(); |
There was a problem hiding this comment.
Suggested change
| public Response deleteUserFromGroup(@PathParam(GROUP_ID) Group group, @PathParam(USER_ID) UserId user) { | |
| processor.deleteUserFromGroup(group, user); | |
| return Response.ok().build(); | |
| public void deleteUserFromGroup(@PathParam(GROUP_ID) Group group, @PathParam(USER_ID) UserId user) { | |
| processor.deleteUserFromGroup(group, user); |
Comment on lines
+50
to
52
| public Response deleteRole(@PathParam(ROLE_ID) RoleId role) throws JSONException { | ||
| processor.deleteRole(role); | ||
| return Response.ok().build(); |
There was a problem hiding this comment.
Suggested change
| public Response deleteRole(@PathParam(ROLE_ID) RoleId role) throws JSONException { | |
| processor.deleteRole(role); | |
| return Response.ok().build(); | |
| public void deleteRole(@PathParam(ROLE_ID) RoleId role) throws JSONException { | |
| processor.deleteRole(role); |
Comment on lines
+107
to
+111
| User user = getStorage().getUser(id); | ||
| if (user != null) { | ||
| return getUserContent(user); | ||
| } | ||
| return FrontendUserContent.builder().id(id).build(); |
There was a problem hiding this comment.
lässt sich das nicht in getUserContent(UserId) einbetten?
Comment on lines
+58
to
61
| public Response deleteUser(@PathParam(USER_ID) UserId user) { | ||
| processor.deleteUser(user); | ||
| return Response.ok().build(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public Response deleteUser(@PathParam(USER_ID) UserId user) { | |
| processor.deleteUser(user); | |
| return Response.ok().build(); | |
| } | |
| public void deleteUser(@PathParam(USER_ID) UserId user) { | |
| processor.deleteUser(user); | |
| } |
Comment on lines
+65
to
67
| public Response deleteRoleFromUser(@PathParam(USER_ID) User user, @PathParam(ROLE_ID) RoleId role) { | ||
| processor.deleteRoleFrom(user, role); | ||
| return Response.ok().build(); |
There was a problem hiding this comment.
Suggested change
| public Response deleteRoleFromUser(@PathParam(USER_ID) User user, @PathParam(ROLE_ID) RoleId role) { | |
| processor.deleteRoleFrom(user, role); | |
| return Response.ok().build(); | |
| public void deleteRoleFromUser(@PathParam(USER_ID) User user, @PathParam(ROLE_ID) RoleId role) { | |
| processor.deleteRoleFrom(user, role); |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.