Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic is not pinned in pyproject.toml or requirements.txt #274

Closed
miguelpher opened this issue Jul 3, 2023 · 2 comments · Fixed by #278
Closed

Pydantic is not pinned in pyproject.toml or requirements.txt #274

miguelpher opened this issue Jul 3, 2023 · 2 comments · Fixed by #278
Labels
dependencies Pull requests that update a dependency file

Comments

@miguelpher
Copy link

Pydantic has recently been updated to v2.0 (2023-06-30), but it is not pinned in pyproject.toml or requirements.txt. Could you please either update it or pin the version?

File "..../lib/python3.10/site-packages/popmon/config.py", line 24, in <module>
    from pydantic import BaseModel, BaseSettings
  File "..../lib/python3.10/site-packages/pydantic/__init__.py", line 206, in __getattr__
    return _getattr_migration(attr_name)
  File "..../lib/python3.10/site-packages/pydantic/_migration.py", line 279, in wrapper
    raise PydanticImportError(
pydantic.errors.PydanticImportError: `BaseSettings` has been moved to the `pydantic-settings` package. See https://docs.pydantic.dev/2.0/migration/#basesettings-has-moved-to-pydantic-settings for more details.
@sbrugman sbrugman added the dependencies Pull requests that update a dependency file label Jul 6, 2023
@sbrugman
Copy link
Collaborator

sbrugman commented Jul 6, 2023

Indeed, we should upgrade!

sbrugman added a commit that referenced this issue Jul 6, 2023
@sbrugman sbrugman mentioned this issue Jul 6, 2023
sbrugman added a commit that referenced this issue Jul 6, 2023
@sbrugman sbrugman linked a pull request Jul 6, 2023 that will close this issue
sbrugman added a commit that referenced this issue Jul 6, 2023
@miguelpher
Copy link
Author

Thank you @sbrugman !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants