This repository has been archived by the owner on May 4, 2022. It is now read-only.
Fix staticcheck and CI #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're using ubi8 now as the base image, it runs golang 1.14 which deprecates the usage of tlsConfig.NameToCertificate. The suggestion is to simply remove it from the code base.
pleimer
approved these changes
Mar 17, 2021
paramite
pushed a commit
that referenced
this pull request
Mar 17, 2021
* condition on type assertion * Fix staticcheck and CI (#101) * Drop tlsConfig.NameToCertificate as it's deprecated on golang 1.14 Since we're using ubi8 now as the base image, it runs golang 1.14 which deprecates the usage of tlsConfig.NameToCertificate. The suggestion is to simply remove it from the code base. * Use ubi8 vs centos8 for testing Co-authored-by: Leif Madsen <[email protected]>
pleimer
added a commit
that referenced
this pull request
Mar 17, 2021
…retreival hotfix (#100) * condition on type assertion * Fix staticcheck and CI (#101) * Drop tlsConfig.NameToCertificate as it's deprecated on golang 1.14 Since we're using ubi8 now as the base image, it runs golang 1.14 which deprecates the usage of tlsConfig.NameToCertificate. The suggestion is to simply remove it from the code base. * Use ubi8 vs centos8 for testing Co-authored-by: Leif Madsen <[email protected]>
leifmadsen
added a commit
that referenced
this pull request
Mar 17, 2021
…retreival hotfix (#100) (#102) * condition on type assertion * Fix staticcheck and CI (#101) * Drop tlsConfig.NameToCertificate as it's deprecated on golang 1.14 Since we're using ubi8 now as the base image, it runs golang 1.14 which deprecates the usage of tlsConfig.NameToCertificate. The suggestion is to simply remove it from the code base. * Use ubi8 vs centos8 for testing Co-authored-by: Leif Madsen <[email protected]> Co-authored-by: Leif Madsen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix staticcheck issue with golang 1.14 and update CI to use ubi8 as the base image vs centos8.