Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup SG3 CI system #59

Merged
merged 6 commits into from
Jul 13, 2020
Merged

Setup SG3 CI system #59

merged 6 commits into from
Jul 13, 2020

Conversation

leifmadsen
Copy link
Member

Setup SG3 to work with the new CI setup.

Related: infrawatch/service-telemetry-operator#107

@leifmadsen leifmadsen added the enhancement New feature or request label Jul 13, 2020
@leifmadsen leifmadsen self-assigned this Jul 13, 2020
Lock operator-courier to 2.1.7 until we can figure out what is wrong with our CSV/CRD setup
or until the operator-courier issue noted in the related issue is resolved.

Related: infrawatch/service-telemetry-operator#108
@leifmadsen leifmadsen marked this pull request as ready for review July 13, 2020 17:57
Copy link
Contributor

@csibbitt csibbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion in-line, otherwise LGTM!

@@ -7,7 +7,7 @@ language: python
git:
depth: 1
install:
- pip install operator-courier
- pip install operator-courier==2.1.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -18,6 +18,8 @@
loop:
- name: events-configmap.yaml.j2
to_load: "{{ True if 'events' in service_type else False }}"
- name: ceilometer-metrics-configmap.yaml.j2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -0,0 +1,24 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, this file is called metrics-configmap.yaml.j2 on master and was previously removed from this branch, but is still needed for ceilometer metrics with the legacy SG.

@leifmadsen leifmadsen merged commit 3a2a7bf into sg3-bz1805468 Jul 13, 2020
@leifmadsen leifmadsen deleted the lmadsen-sg3-ci-passing branch July 13, 2020 21:28
leifmadsen added a commit that referenced this pull request Jul 13, 2020
* Changes for sg2

* Added new containers images for sg2 and bridge
* Added socket-dir for them to communicate
* Added more mode-specific code to deployment template
* Removed now-unused metrics-configmap

* Use best bridge args from testing

* Updated CSV and container values for new SG

* Updated core image name & scorecard

* fixed "replaced" line in csv

* Adjust template to support ceilometer metrics too

* Update description in CSV (#53)

Update the CSV description so that we could pass upstream Community Operator requirements
should we ever publish there.

* amqpDataSource should be amqp_data_source

* Misplaced conditionals broke volume

* Setup SG3 CI system (#59)

* Use new connection configuration for metrics (#48)

AMQP1Connections parameter should be used instead of nonflexible AMQP1Url.

Depends-On: infrawatch/smart-gateway#83

* Bump default CSV to 2.0.0

* Fix file rename

* Lock operator-courier to v2.1.7

Lock operator-courier to 2.1.7 until we can figure out what is wrong with our CSV/CRD setup
or until the operator-courier issue noted in the related issue is resolved.

Related: infrawatch/service-telemetry-operator#108

* Update roles/smartgateway/templates/ceilometer-metrics-configmap.yaml.j2

Co-authored-by: Chris Sibbitt <[email protected]>

Co-authored-by: Martin Mágr <[email protected]>
Co-authored-by: Chris Sibbitt <[email protected]>

Co-authored-by: Chris Sibbitt <[email protected]>
Co-authored-by: Martin Mágr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants