Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix amqpDataSource #57

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Fix amqpDataSource #57

merged 2 commits into from
Jul 9, 2020

Conversation

csibbitt
Copy link
Contributor

@csibbitt csibbitt commented Jul 9, 2020

CC: @leifmadsen @paramite purely an FYI PR for a quick fix

Remember when I said I hadn't tested the amqpDataSource change?

First it did this:

fatal: [localhost]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'amqpDataSource' is undefined\n\nThe error appears to be in '/opt/ansible/roles/smartgateway/tasks/main.yml': line 13, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Setup Smart Gateway\n  ^ here\n"}

Turned out to the the ^*@#ing camelCase to snake_case auto-converter biting me again!

Then it did this:

failed: [localhost] (item={'name': 'deployment.yaml.j2'}) => {"ansible_loop_var": "item", "changed": false, "error": 422, "item": {"name": "deployment.yaml.j2"}, "msg": "Failed to create object: b'{\"kind\":\"Status\",\"apiVersion\":\"v1\",\"metadata\":{},\"status\":\"Failure\",\"message\":\"Deployment.apps \\\\\"stf-default-collectd-telemetry-smartgateway\\\\\" is invalid: [spec.template.spec.containers[0].volumeMounts[0].name: Not found: \\\\\"socket-dir\\\\\", spec.template.spec.containers[1].volumeMounts[0].name: Not found: \\\\\"socket-dir\\\\\"]\",\"reason\":\"Invalid\",\"details\":{\"name\":\"stf-default-collectd-telemetry-smartgateway\",\"group\":\"apps\",\"kind\":\"Deployment\",\"causes\":[{\"reason\":\"FieldValueNotFound\",\"message\":\"Not found: \\\\\"socket-dir\\\\\"\",\"field\":\"spec.template.spec.containers[0].volumeMounts[0].name\"},{\"reason\":\"FieldValueNotFound\",\"message\":\"Not found: \\\\\"socket-dir\\\\\"\",\"field\":\"spec.template.spec.containers[1].volumeMounts[0].name\"}]},\"code\":422}\\n'", "reason": "Unprocessable Entity", "status": 422}

One of the new conditionals broke the volume definitions in the deployment.

Now it does this:

stf-default-collectd-telemetry-smartgateway-78b7ccb674-22d29      2/2     Running   0          8s

and this:

*** [SUCCESS] Smoke test job completed successfully

@csibbitt csibbitt merged commit fece147 into sg3-bz1805468 Jul 9, 2020
@csibbitt csibbitt deleted the csibbitt-fix-amqpdatasource branch July 9, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant