Update base image to RH UBI 9 and Golang 1.22 #138
Conversation
vkmc
force-pushed
the
vkmc-migrate-rhel9-golang-1222
branch
2 times, most recently
from
7ef17cd to
01917e4
Compare
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e81e8f8cbd244d89b7eccb33dddd55f0 ❌ stf-crc-ocp_414-local_build FAILURE in 37m 56s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/df0dad5bb9484d73bb75ef94bdc868ec ❌ stf-crc-ocp_414-local_build FAILURE in 37m 48s |
vkmc
changed the title
vkmc
changed the title
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/77cdfa4ba6784bda9d73428747a30ccd ❌ stf-crc-ocp_414-local_build FAILURE in 37m 45s |
vkmc
force-pushed
the
vkmc-migrate-rhel9-golang-1222
branch
2 times, most recently
from
6b89a04 to
9a339cd
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/313e17807ca34050a937b80ada16aad2 ✔️ stf-crc-ocp_414-local_build SUCCESS in 33m 35s |
vkmc
force-pushed
the
vkmc-migrate-rhel9-golang-1222
branch
2 times, most recently
from
d2cc4ba to
8a1a126
Compare
vkmc
force-pushed
the
vkmc-migrate-rhel9-golang-1222
branch
2 times, most recently
from
bfd8e67 to
0b96faa
Compare
Use golang 1.22.0 instead of golang 1.22. Since 1.21 golang added the .z version, so it is now required to point to a z version Use OpenStack RDO Caracal repos to fetch dependencies
Also fixes the golang version we want to use (includes the z version)
Missing the z version
Disable depguard, gosec and revive linters We should fix the issues in a follow up patch
Use Prometheus image from Quay instead of the Prometheus image in the Docker registry
Add z version when retrieving golang binaries
Use the latest z version available for golang
vkmc
force-pushed
the
vkmc-migrate-rhel9-golang-1222
branch
from
0b96faa to
f57517b
Compare
We are now consuming centos9-caracal repos (OpenStack repos) to get the required dependencies, so update the repo to centos9-caracal and all the references in the Github actions and integration scripts Add some other cleanups when setting up the repo Also fix logging integration scripts missing golang 1.22 microversion
|
Last missing piece here is coveralls and linting. Seems coveralls golang plugin hasn't been updated for a year already, and their own repo reflects low coverage. See https://github.com/shogo82148/actions-goveralls. We should look for an alternative or just drop it. In the case of linting, I had to disable a few linters since the changes required to get it passing might be better done in a follow up patch. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8e293c3611574f31804cd7ca3fb77ea9 ✔️ stf-crc-ocp_414-local_build SUCCESS in 32m 43s |
| @@ -74,7 +74,7 @@ jobs: | |||
| if: steps.bridge_branch.outcome == 'success' | |||
| run: | | |||
| docker run --name=sgbridge --network host $BRIDGE_VOLUME -d -uroot \ | |||
| -e GITHUB_REF -e BRIDGE_SOCKET -e QDR_CHANNEL -e OPSTOOLS_REPO \ | |||
| -e GITHUB_HEAD_REF -e BRIDGE_SOCKET -e QDR_CHANNEL -e OPENSTACK_REPO \ | |||
There was a problem hiding this comment.
How did you notice this and why does it matter here? I would have though you can pull from either ref for building purposes.
|
|
||
| linters: | ||
| disable-all: true | ||
| enable: | ||
| - bodyclose | ||
| - depguard | ||
| # - depguard |
There was a problem hiding this comment.
Did you look into replacements for any of these disabled linters? Sometimes there is a 1:1 replacement or a spiritual successor mentioned in the release notes.
No description provided.