Get IPAddress if resource already has IP assigned #86
+280
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraphQL Schema CheckCompared 0 schema changes against null operations ✅ Found no changes |
Description: Ipam-api service should have generic logic to return the IP address from the nodeID. Existing ipamclient GetIPAddresses API fetches loadbalancer resources from the nodeID provided. Added ability to check if a resource already has an IP address assigned before allocating a new one from IPAM Service. This PR includes, - Update ipaddress GraphQL schema with ipAddressByNode query API - Implement the IPAddressByNode which queries NodeID and fetch the first instance - IpamClient API implementation for GetIPAddressByNode - Define the supported ipamclient type for newly added API - Unit test coverage for IPAddressByNode Graph API - Unit test coverage for new ipamclient API - Locally verified to fetch the IP Address from the NodeID Signed-off-by: Tamilselvan R <[email protected]>
Signed-off-by: Tamilselvan R <[email protected]>
tramachandran-equinix
force-pushed
the
getIpByNode
branch
from
e45fa4e
to
0f62f92
Compare
|
We already have this logic through the super graph effectively. So I'm not sure why this would be needed. On any object that is ip addressable we add the ipAddresses field to which provides the same functionality without a dedicated call basically. |
There are two points to consider here,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ipam-api service should have generic logic to return the IP address from the nodeID. Existing ipamclient GetIPAddresses API fetches loadbalancer resources from the nodeID provided. Added ability to check if a resource already has an IP address assigned before allocating a new one from IPAM Service.
This PR includes,