add support for SRV discovery for permissions-api host #98
+2,531
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage ? 35.33%
=======================================
Files ? 27
Lines ? 1715
Branches ? 0
=======================================
Hits ? 606
Misses ? 1089
Partials ? 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mikemrm
force-pushed
the
support-srv-records
branch
3 times, most recently
from
afa25c0
to
9e4eb16
Compare
mikemrm
force-pushed
the
support-srv-records
branch
2 times, most recently
from
d4d686f
to
00b69d2
Compare
To better support failover to other regions without adding load balancer hops and latency, permissions hosts can now support SRV record discovery to discover additional hosts which can serve requests. SRV records are looked up host configured for the permissions client. The SRV service looked up is `permissions-api` with protocol `tcp`. An example SRV lookup request would be for `_permissions-api._tcp.iam.example.com`. Where `iam.example.com` is the host configured for `permissions.host`. For best backwards compatibility, these SRV records are optional and will fallback to using the value provided in `permissions.host`. Additionally, to support retrying on failure, the permissions client was updated to support retrying auth checks if the response was not successful. This ensures a seamless transition when a host has failed between health checks. Signed-off-by: Mike Mason <[email protected]>
mikemrm
force-pushed
the
support-srv-records
branch
from
00b69d2
to
255e543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better support failover to other regions without adding load balancer hops and latency, permissions hosts can now support SRV record discovery to discover additional hosts which can serve requests.
SRV records are looked up host configured for the permissions client. The SRV service looked up is
permissions-apiwith protocoltcp. An example SRV lookup request would be for_permissions-api._tcp.iam.example.com. Whereiam.example.comis the host configured forpermissions.host.For best backwards compatibility, these SRV records are optional and will fallback to using the value provided in
permissions.host.