support client credentials being loaded from file #48
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client creds secret, previously had to be specified in the config. When deploying this with the helm chart, this would require the value to be stored in plain text in the config map. To solve this, we now accept a file path for both clientID and clientSecret. If either attributes value is prefixed with `file://` the defined file is attempted to be loaded. If no file is found, or the file fails to be read, an error is returned. Currently the file is only read once at startup. However a future improvement could provide support for allowing hot reloading of the file. Signed-off-by: Mike Mason <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage ? 10.89%
=======================================
Files ? 22
Lines ? 679
Branches ? 0
=======================================
Hits ? 74
Misses ? 600
Partials ? 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jnschaeffer
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client creds secret, previously had to be specified in the config. When deploying this with the helm chart, this would require the value to be stored in plain text in the config map.
To solve this, we now accept a file path for both clientID and clientSecret.
If either attributes value is prefixed with
file://the defined file is attempted to be loaded. If no file is found, or the file fails to be read, an error is returned.Currently the file is only read once at startup.
However a future improvement could provide support for allowing hot reloading of the file.