Multi-select functionality for chaise #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFSH
reviewed
Aug 7, 2017
js/reference.js
Outdated
| * @type {string} | ||
| */ | ||
| get uniqueId() { | ||
| if (!this._uniqueId) { |
There was a problem hiding this comment.
Change this check to this_uniqueId === undefined to be consistent with other apis.
|
It seems like you have the "Remove Trailing Whitespace" turned on in atom and it's adding unnecessary changes to the code. It seems like the only change that you have done in the |
|
@RFSH this Pr is ready for review again. I changed the operator to |
RFSH
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides some additions to the
ermrestJSAPI to support multi-select functionality in the recordset directive inchaise. Changes in this PR include:uniqueIdfunction toTupleso eachTuplecan be identified by a unique identifier when keeping track of currently selected rowsArray.findIndexbecause it is not supported in IE.Array.clearas well for emptying out an array.This PR is required to be merged before the corresponding chaise PR. This PR helps to fix issue #1211 in chaise.