Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OH2-430 - OH2-434 | Fix edit group component and update text field component #697

Merged
merged 1 commit into from
Nov 25, 2024
Merged

OH2-430 - OH2-434 | Fix edit group component and update text field component #697

merged 1 commit into from
Nov 25, 2024

Conversation

SteveGT96
Copy link
Contributor

@SteveGT96 SteveGT96 commented Nov 20, 2024 •
edited by jira bot
Loading

See OH2-430 and OH2-434.

@mwithi mwithi requested a review from SilverD3 November 20, 2024 16:15
mwithi
mwithi approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, although I think it could be further improved... @SilverD3 wdyt?

SilverD3
SilverD3 reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@SilverD3 SilverD3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only focuses on OH2-434, I think. I'm not seeing any changes that could improve (performance) user group edition

@mwithi
Copy link
Member

mwithi commented Nov 21, 2024 •
edited
Loading

This PR only focuses on OH2-434, I think. I'm not seeing any changes that could improve (performance) user group edition

Isn't the fix for OH2-434 only the change on src/components/accessories/textField/TextField.tsx and the rest for OH2-430?

@SilverD3
Copy link
Contributor

I know why user group edition is slow. I just don't know how to optimize yet. This PR doesn't get to the heart of the problem, but it's a start.

@mwithi mwithi merged commit 3ce420a into informatici:develop Nov 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilverD3 SilverD3 SilverD3 left review comments

@mwithi mwithi mwithi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SteveGT96 @mwithi @SilverD3