tools: Fix `block_search` endpoint integration tests #999

thanethomson · 2021-09-29T14:40:12Z

Closes #998

Referenced an issue explaining the need for the change
Updated all relevant documentation in docs
Updated all code comments where relevant
Wrote tests
Added entry in .changelog/

Signed-off-by: Thane Thomson <[email protected]>

thanethomson · 2021-09-29T14:51:37Z

tools/kvstore-test/tests/tendermint.rs

-                1,
-                Order::Ascending,
-            )
+            .block_search(Query::gt("block.height", 1), 1, 1, Order::Ascending)


The original string representation was breaking CI. Changing it to a numerical value fixed it.

thanethomson · 2021-09-29T14:52:33Z

tools/kvstore-test/tests/tendermint.rs

@@ -264,15 +260,21 @@ mod rpc {
    }

    async fn transaction_by_hash() {
+        let rpc_client = localhost_http_client();


These tests kept failing locally so I had to tweak them here too.

codecov-commenter · 2021-09-29T16:09:37Z

Codecov Report

Merging #999 (a9c86c1) into master (34c5d2a) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #999   +/-   ##
======================================
  Coverage    72.5%   72.5%           
======================================
  Files         204     204           
  Lines       16655   16655           
======================================
+ Hits        12078   12081    +3     
+ Misses       4577    4574    -3

Impacted Files	Coverage Δ
light-client/src/types.rs	`41.0% <0.0%> (ø)`
tendermint/src/node.rs	`66.1% <0.0%> (+0.2%)`	⬆️
tendermint/src/block/commit_sig.rs	`78.7% <0.0%> (+2.1%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c5d2a...a9c86c1. Read the comment docs.

thanethomson · 2021-09-29T17:44:03Z

.github/workflows/test.yml

@@ -125,7 +125,7 @@ jobs:
    runs-on: ubuntu-latest
    services:
      tendermint:
-        image: informaldev/tendermint:0.34.0
+        image: informaldev/tendermint:0.34.13


Important to note here that the block_search endpoint was only introduced in Tendermint v0.34.9.

thanethomson · 2021-09-29T17:45:07Z

tools/kvstore-test/Makefile.toml

@@ -1,6 +1,6 @@
 [env]
 CONTAINER_NAME = "kvstore-test"
-DOCKER_IMAGE = "informaldev/tendermint:0.34.0"
+DOCKER_IMAGE = "informaldev/tendermint:0.34.13"


Note that this needs to be maintained separately and coordinated with the .github/workflows/test.yml config because this cargo make makefile allows you to run the same tests locally.

xla

💢 🍆 📹 🍷

* Fix `cargo test` and add check to CI (#990) * Relocate ABCI test to fix broken doctest Signed-off-by: Thane Thomson <[email protected]> * Use tokio_test for mock client doctest Signed-off-by: Thane Thomson <[email protected]> * Add CI test for default features Signed-off-by: Thane Thomson <[email protected]> * Add `block_search` RPC endpoint (#991) * Add block_search RPC endpoint and tests * Add .changelog entry * Fix comments * tools: Fix `block_search` endpoint integration tests (#999) Closes #998 * Bump integration test tendermint to v0.34.13 * Fix kvstore integration tests * Bump tendermint version to v0.34.13 in CI Signed-off-by: Thane Thomson <[email protected]> * ci: Build and check tools (#997) So far only the kvstore tests ran as part of the Github workfows. This would leave opportunity for changes to introduce breakage to the builds of the tools. In this change the same build and clippy stages are introduced for the tools workspace that currently run for the top-level one. Signed-off-by: xla <[email protected]> * tools: Add `block_search` method to RPC probe (#1002) * Add missing block_search endpoint * Bump tendermint version to v0.34.13 Signed-off-by: Thane Thomson <[email protected]> Co-authored-by: Shoaib Ahmed <[email protected]> Co-authored-by: xla <[email protected]>

* Move out tendermint::config to tendermint_config crate * Introduce own error type in tendermint-config * Move tendermint::net to tendermint_config::net * Fix tendermint-rpc error * Update Cargo.toml for tendermint-config * Remove #![allow(dead_code)] * Apply suggestions from code review Co-authored-by: Thane Thomson <[email protected]> * Move tendermint_config::files::test to tendermint_config::test * Remove config/tests/config.rs * Minor fixes * Resolve conflict in #986 (#1004) * Fix `cargo test` and add check to CI (#990) * Relocate ABCI test to fix broken doctest Signed-off-by: Thane Thomson <[email protected]> * Use tokio_test for mock client doctest Signed-off-by: Thane Thomson <[email protected]> * Add CI test for default features Signed-off-by: Thane Thomson <[email protected]> * Add `block_search` RPC endpoint (#991) * Add block_search RPC endpoint and tests * Add .changelog entry * Fix comments * tools: Fix `block_search` endpoint integration tests (#999) Closes #998 * Bump integration test tendermint to v0.34.13 * Fix kvstore integration tests * Bump tendermint version to v0.34.13 in CI Signed-off-by: Thane Thomson <[email protected]> * ci: Build and check tools (#997) So far only the kvstore tests ran as part of the Github workfows. This would leave opportunity for changes to introduce breakage to the builds of the tools. In this change the same build and clippy stages are introduced for the tools workspace that currently run for the top-level one. Signed-off-by: xla <[email protected]> * tools: Add `block_search` method to RPC probe (#1002) * Add missing block_search endpoint * Bump tendermint version to v0.34.13 Signed-off-by: Thane Thomson <[email protected]> Co-authored-by: Shoaib Ahmed <[email protected]> Co-authored-by: xla <[email protected]> * Fix abci-test * Add changelog entry Signed-off-by: Thane Thomson <[email protected]> * Add more changelog entries for other breaking changes Signed-off-by: Thane Thomson <[email protected]> * Add tendermint-config to release script Signed-off-by: Thane Thomson <[email protected]> * Fix merge mistakes Co-authored-by: Thane Thomson <[email protected]> Co-authored-by: Shoaib Ahmed <[email protected]> Co-authored-by: xla <[email protected]> Co-authored-by: Thane Thomson <[email protected]>

thanethomson added 2 commits September 29, 2021 10:39

Bump integration test tendermint to v0.34.13

76c6110

Signed-off-by: Thane Thomson <[email protected]>

Fix kvstore integration tests

c49e110

Signed-off-by: Thane Thomson <[email protected]>

xla changed the title ~~Fix block_search endpoint integration tests~~ tools: Fix block_search endpoint integration tests Sep 29, 2021

Bump tendermint version to v0.34.13 in CI

a9c86c1

Signed-off-by: Thane Thomson <[email protected]>

thanethomson commented Sep 29, 2021

View reviewed changes

thanethomson marked this pull request as ready for review September 29, 2021 14:53

thanethomson requested a review from xla September 29, 2021 14:55

thanethomson requested a review from hu55a1n1 September 29, 2021 17:42

thanethomson commented Sep 29, 2021

View reviewed changes

xla approved these changes Sep 29, 2021

View reviewed changes

xla merged commit 4f1c553 into master Sep 30, 2021

xla deleted the thane/998-block-search branch September 30, 2021 00:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: Fix `block_search` endpoint integration tests #999

tools: Fix `block_search` endpoint integration tests #999

thanethomson commented Sep 29, 2021

thanethomson Sep 29, 2021 •

edited

Loading

thanethomson Sep 29, 2021

codecov-commenter commented Sep 29, 2021

thanethomson Sep 29, 2021

thanethomson Sep 29, 2021

xla left a comment

tools: Fix block_search endpoint integration tests #999

tools: Fix block_search endpoint integration tests #999

Conversation

thanethomson commented Sep 29, 2021

thanethomson Sep 29, 2021 • edited Loading

Choose a reason for hiding this comment

thanethomson Sep 29, 2021

Choose a reason for hiding this comment

codecov-commenter commented Sep 29, 2021

Codecov Report

thanethomson Sep 29, 2021

Choose a reason for hiding this comment

thanethomson Sep 29, 2021

Choose a reason for hiding this comment

xla left a comment

Choose a reason for hiding this comment

tools: Fix `block_search` endpoint integration tests #999

tools: Fix `block_search` endpoint integration tests #999

thanethomson Sep 29, 2021 •

edited

Loading