-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for time_iota_ms
default
#933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
romac
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
thanethomson
added a commit
that referenced
this pull request
Jul 16, 2021
* Specify default value for `tendermint::block::Size` * Add .changelog entry * Add test for `time_iota_ms` default (#933) * Bump supported rpc-probe version of Tendermint to v0.34.9 * Regenerate kvstore fixtures using Tendermint v0.34.9 * Update kvstore tests to test #931 * Expose Size::default_time_iota_ms to access from integration test * Implement test for #931 Co-authored-by: Thane Thomson <[email protected]>
romac
added a commit
that referenced
this pull request
Jul 19, 2021
* Specify default value for `tendermint::block::Size` * Add .changelog entry * Add test for `time_iota_ms` default (#933) * Bump supported rpc-probe version of Tendermint to v0.34.9 * Regenerate kvstore fixtures using Tendermint v0.34.9 * Update kvstore tests to test #931 * Expose Size::default_time_iota_ms to access from integration test * Implement test for #931 Co-authored-by: Thane Thomson <[email protected]>
thanethomson
added a commit
that referenced
this pull request
Jul 19, 2021
* Propagate JSON-RPC errors through the Rust subscription * Fix clippy warnings * Add .changelog entry * Update .changelog/unreleased/improvements/932-propagate-json-rpc-errors.md Co-authored-by: Thane Thomson <[email protected]> * Update rpc/src/client/transport/router.rs Co-authored-by: Thane Thomson <[email protected]> * Specify default value for `tendermint::block::Size` (#931) * Specify default value for `tendermint::block::Size` * Add .changelog entry * Add test for `time_iota_ms` default (#933) * Bump supported rpc-probe version of Tendermint to v0.34.9 * Regenerate kvstore fixtures using Tendermint v0.34.9 * Update kvstore tests to test #931 * Expose Size::default_time_iota_ms to access from integration test * Implement test for #931 Co-authored-by: Thane Thomson <[email protected]> * Remove subscription id to query index in `SubscriptionRouter` * Introduce type aliases for subscription ids and queries * Fix dead code warnings when `websocket` feature is disabled * Update .changelog/unreleased/bug-fixes/930-newblock-event-parse.md Co-authored-by: Thane Thomson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a small test for #931.
Updates the kvstore fixtures to v0.34.9. Doesn't look like there's anything substantially different here, but I suppose it's good to keep this in sync.
.changelog/