Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for time_iota_ms default #933

Merged
merged 5 commits into from
Jul 16, 2021

Conversation

thanethomson
Copy link
Contributor

This adds a small test for #931.

Updates the kvstore fixtures to v0.34.9. Doesn't look like there's anything substantially different here, but I suppose it's good to keep this in sync.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@thanethomson thanethomson requested a review from romac July 16, 2021 12:46
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@romac romac merged commit 08d7c95 into romac/fix-new-block-parse Jul 16, 2021
@romac romac deleted the thane/931-add-test branch July 16, 2021 12:52
thanethomson added a commit that referenced this pull request Jul 16, 2021
* Specify default value for `tendermint::block::Size`

* Add .changelog entry

* Add test for `time_iota_ms` default (#933)

* Bump supported rpc-probe version of Tendermint to v0.34.9
* Regenerate kvstore fixtures using Tendermint v0.34.9
* Update kvstore tests to test #931
* Expose Size::default_time_iota_ms to access from integration test
* Implement test for #931

Co-authored-by: Thane Thomson <[email protected]>
romac added a commit that referenced this pull request Jul 19, 2021
* Specify default value for `tendermint::block::Size`

* Add .changelog entry

* Add test for `time_iota_ms` default (#933)

* Bump supported rpc-probe version of Tendermint to v0.34.9
* Regenerate kvstore fixtures using Tendermint v0.34.9
* Update kvstore tests to test #931
* Expose Size::default_time_iota_ms to access from integration test
* Implement test for #931

Co-authored-by: Thane Thomson <[email protected]>
thanethomson added a commit that referenced this pull request Jul 19, 2021
* Propagate JSON-RPC errors through the Rust subscription

* Fix clippy warnings

* Add .changelog entry

* Update .changelog/unreleased/improvements/932-propagate-json-rpc-errors.md

Co-authored-by: Thane Thomson <[email protected]>

* Update rpc/src/client/transport/router.rs

Co-authored-by: Thane Thomson <[email protected]>

* Specify default value for `tendermint::block::Size` (#931)

* Specify default value for `tendermint::block::Size`

* Add .changelog entry

* Add test for `time_iota_ms` default (#933)

* Bump supported rpc-probe version of Tendermint to v0.34.9
* Regenerate kvstore fixtures using Tendermint v0.34.9
* Update kvstore tests to test #931
* Expose Size::default_time_iota_ms to access from integration test
* Implement test for #931

Co-authored-by: Thane Thomson <[email protected]>

* Remove subscription id to query index in `SubscriptionRouter`

* Introduce type aliases for subscription ids and queries

* Fix dead code warnings when `websocket` feature is disabled

* Update .changelog/unreleased/bug-fixes/930-newblock-event-parse.md

Co-authored-by: Thane Thomson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants