Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sled-based light store #773

Merged
merged 13 commits into from
Jan 22, 2021
Merged

Improve sled-based light store #773

merged 13 commits into from
Jan 22, 2021

Conversation

romac
Copy link
Member

@romac romac commented Jan 5, 2021

Close: #769

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@romac romac added the light-client Issues/features which involve the light client label Jan 5, 2021
@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #773 (cda64a8) into master (97532b3) will increase coverage by 3.3%.
The diff coverage is 62.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #773     +/-   ##
========================================
+ Coverage    50.4%   53.8%   +3.3%     
========================================
  Files         197     197             
  Lines       13607   13682     +75     
  Branches     3266    3284     +18     
========================================
+ Hits         6870    7369    +499     
+ Misses       6475    5946    -529     
- Partials      262     367    +105     
Impacted Files Coverage Δ
light-client/src/builder/light_client.rs 0.0% <ø> (ø)
light-client/src/components/scheduler.rs 0.0% <0.0%> (ø)
light-client/src/light_client.rs 57.8% <ø> (ø)
light-client/src/supervisor.rs 28.6% <0.0%> (ø)
light-client/src/utils/std_ext.rs 31.2% <0.0%> (-14.3%) ⬇️
light-node/src/commands/initialize.rs 0.0% <0.0%> (ø)
light-node/src/commands/start.rs 0.0% <0.0%> (ø)
light-client/src/store/memory.rs 35.4% <14.2%> (-5.1%) ⬇️
light-client/src/store.rs 40.6% <30.0%> (-11.4%) ⬇️
light-client/src/store/sled/utils.rs 55.3% <70.2%> (+55.3%) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97532b3...cda64a8. Read the comment docs.

@romac romac marked this pull request as ready for review January 8, 2021 10:26
@romac romac marked this pull request as draft January 21, 2021 11:19
@romac romac marked this pull request as ready for review January 21, 2021 16:06
@romac
Copy link
Member Author

romac commented Jan 21, 2021

Note: LightStore::lowest_trusted_or_verified is not currently used but will be useful for improving performance of backward verification.

Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@thanethomson thanethomson merged commit f337b26 into master Jan 22, 2021
@thanethomson thanethomson deleted the romac/sled-better branch January 22, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
light-client Issues/features which involve the light client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encode heights used as keys in sled-based lightstore in big-endian representation
3 participants