-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve sled-based light store #773
Conversation
…epresentation One needs to represent the keys in big-endian form for sled's iterators and ordered operations to work properly. See [1] and [2] for more information. [1] https://github.com/spacejam/sled#a-note-on-lexicographic-ordering-and-endianness [2] https://github.com/spacejam/sled/blob/aa3fcf37d844e2d1382e0a58267dc3b3ae3b25aa/examples/structured.rs#L23-L30
…store This avoids a full linear scan, and is even likely constant time.
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
========================================
+ Coverage 50.4% 53.8% +3.3%
========================================
Files 197 197
Lines 13607 13682 +75
Branches 3266 3284 +18
========================================
+ Hits 6870 7369 +499
+ Misses 6475 5946 -529
- Partials 262 367 +105
Continue to review full report at Codecov.
|
Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍
Close: #769