Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode heights used as keys in sled-based light store in big-endian representation #768

Closed
wants to merge 1 commit into from
Closed

Encode heights used as keys in sled-based light store in big-endian representation #768

wants to merge 1 commit into from

Conversation

romac
Copy link
Member

@romac romac commented Jan 5, 2021 •
edited
Loading

Close #769

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@romac romac added the light-client Issues/features which involve the light client label Jan 5, 2021
@romac romac modified the milestones: v0.17.0, v0.17.1 Jan 5, 2021
@romac romac marked this pull request as draft January 5, 2021 15:17
@codecov-io
Copy link

Codecov Report

Merging #768 (4fbf84b) into master (e65337a) will increase coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #768   +/-   ##
======================================
  Coverage    50.6%   50.6%           
======================================
  Files         197     197           
  Lines       13567   13562    -5     
  Branches     3249    3242    -7     
======================================
  Hits         6869    6869           
+ Misses       6336    6334    -2     
+ Partials      362     359    -3
Impacted Files Coverage Δ
light-client/src/store/sled.rs 0.0% <0.0%> (ø)
light-client/src/store/sled/utils.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65337a...4fbf84b. Read the comment docs.

@romac romac mentioned this pull request Jan 5, 2021
Closed
5 tasks
@romac romac closed this Jan 5, 2021
@romac romac deleted the romac/sled-be branch January 5, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
light-client Issues/features which involve the light client
Projects
None yet
Milestone
v0.17.1
Development

Successfully merging this pull request may close these issues.

Encode heights used as keys in sled-based lightstore in big-endian representation
2 participants
@romac @codecov-io