Added empty option to signature #635
Conversation
| @@ -27,6 +30,9 @@ impl TryFrom<Vec<u8>> for Signature { | |||
| type Error = Error; | |||
|
|
|||
| fn try_from(value: Vec<u8>) -> Result<Self, Self::Error> { | |||
| if value.is_empty() { | |||
There was a problem hiding this comment.
The value sent from Go Tendermint over privval socket (for signing) in Vote/Proposal requests is actually not empty: #626 (comment) -- it has one element which is 0u8.
tmkms could do some preprocessing though and clear that value before creating a domain type
There was a problem hiding this comment.
Apologies, I misunderstood your comment in the issue. And, come on, a single 0u8? Aaaargh.
I'll add that in the code. One more thing to raise to the Go team. Thanks!
There was a problem hiding this comment.
LOL, thanks for checking again! I'm happy to implement extra work if it leads to extra checks! I should have checked it myself...
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
========================================
- Coverage 42.7% 42.7% -0.1%
========================================
Files 167 167
Lines 11602 11613 +11
Branches 2594 2599 +5
========================================
- Hits 4964 4959 -5
- Misses 6347 6362 +15
- Partials 291 292 +1
Continue to review full report at Codecov.
|
|
Tested ACK -- #635 (comment) |
This reverts commit 9ed45f0.
Fixes #626 .
This is a proposed fix for optional signatures.