-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testgen tester #525
Testgen tester #525
Conversation
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
========================================
- Coverage 29.8% 29.6% -0.2%
========================================
Files 135 136 +1
Lines 5515 5681 +166
Branches 1695 1783 +88
========================================
+ Hits 1647 1687 +40
- Misses 2817 2881 +64
- Partials 1051 1113 +62
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @andrey-kuprianov ! I just have a minor change request and few comments on clippy suggestions.
Also, I think it'll be useful to have more code comments if possible ! Otherwise, this looks great!! 🎉
Thanks for your suggesstions, @Shivani912! I have addressed them. Also, it's quite true that the source-level comments are very sparse right now, but what you see here is only a preliminary version of the Tester. I am already extending it substantially further under #414 , and there I will add more documentation. If there are no objections, I would like to merge this PR now, and the PR for #414 will follow shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andrey-kuprianov for explaining.
This looks really good, we have much cleaner and organized code now. Let's merge it !
See #524