Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testgen tester #525

Merged
merged 5 commits into from
Aug 19, 2020
Merged

Testgen tester #525

merged 5 commits into from
Aug 19, 2020

Conversation

andrey-kuprianov
Copy link
Contributor

See #524

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@codecov-commenter
Copy link

Codecov Report

Merging #525 into master will decrease coverage by 0.1%.
The diff coverage is 21.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #525     +/-   ##
========================================
- Coverage    29.8%   29.6%   -0.2%     
========================================
  Files         135     136      +1     
  Lines        5515    5681    +166     
  Branches     1695    1783     +88     
========================================
+ Hits         1647    1687     +40     
- Misses       2817    2881     +64     
- Partials     1051    1113     +62     
Impacted Files Coverage Δ
testgen/src/tester.rs 21.5% <21.5%> (ø)
light-client/src/predicates/errors.rs 4.5% <0.0%> (-10.7%) ⬇️
tendermint/src/block/commit_sig.rs 28.7% <0.0%> (-1.1%) ⬇️
light-client/src/predicates.rs 85.0% <0.0%> (-0.9%) ⬇️
tendermint/src/block/height.rs 41.4% <0.0%> (ø)
tendermint/src/amino_types/vote.rs 28.6% <0.0%> (+0.4%) ⬆️
light-client/src/operations/voting_power.rs 54.8% <0.0%> (+0.7%) ⬆️
tendermint/src/amino_types/proposal.rs 23.2% <0.0%> (+0.8%) ⬆️
light-client/src/types.rs 41.8% <0.0%> (+1.8%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a11d1...45d672e. Read the comment docs.

Copy link
Contributor

@Shivani912 Shivani912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @andrey-kuprianov ! I just have a minor change request and few comments on clippy suggestions.

Also, I think it'll be useful to have more code comments if possible ! Otherwise, this looks great!! 🎉

@xla xla added enhancement New feature or request light-client Issues/features which involve the light client tests labels Aug 18, 2020
@andrey-kuprianov
Copy link
Contributor Author

Thanks for your suggesstions, @Shivani912! I have addressed them. Also, it's quite true that the source-level comments are very sparse right now, but what you see here is only a preliminary version of the Tester. I am already extending it substantially further under #414 , and there I will add more documentation. If there are no objections, I would like to merge this PR now, and the PR for #414 will follow shortly.

Copy link
Contributor

@Shivani912 Shivani912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrey-kuprianov for explaining.
This looks really good, we have much cleaner and organized code now. Let's merge it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request light-client Issues/features which involve the light client tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop a set of model-based tests for the LightClient
4 participants